[PHOENIX-3413] Ineffective null check in LiteralExpression#newConstant()

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.9.1
• Fix Version/s: 4.15.0, 5.1.0, 4.14.2
• Assignee: Kevin Liew
• Reporter: Ted Yu
• Created: 26/Oct/16 21:15
• Updated: 30/May/19 18:40
• Resolved: 06/May/19 23:52

Description

        if (maxLength == null) {
            maxLength = type == null || !type.isFixedWidth() ? null : type.getMaxLength(value);
        }

The null check for type is ineffective - type is de-referenced in various places prior to the above check.