Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-3104 Enable Phoenix test cases with Calcite-Phoenix
  3. PHOENIX-3367

Replace usage of bind variables in BaseTest.createTestTable()

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • None
    • None
    • None

    Description

      We don't support bind variables in DDL yet, due to https://issues.apache.org/jira/browse/CALCITE-1319. So we can probably replace usage of bind variables in BaseTest.createTestTable() with sql string construction. In a previous check-in, I commented out BaseTest.getDefaultSplits() so that this wouldn't have big impact on the pass rate, but once this issue is solved, we can uncomment those lines. Anyway, do you think this is the right thing to do for now, jamestaylor? or should we wait on CALCITE-1319?

      Attachments

        Activity

          People

            Unassigned Unassigned
            maryannxue Wei Xue
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: