[PHOENIX-3113] Automatic build of async index will happen even if mapreduce.framework.name is not set in any configuration

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 4.8.0
• Assignee: Loknath Priyatham Teja Singamsetty
• Reporter: Ankit Singhal
• Created: 25/Jul/16 10:15
• Updated: 11/Aug/16 08:29
• Resolved: 27/Jul/16 07:28

Description

As per below code, we are starting automatic build of async index even if mapreduce.framework.name is not set in any of the configuration(because conf.get(QueryServices.MAPRED_FRAMEWORK_NAME) will always return LOCAL as a default value).
This may cause problem in the hbase cluster where mapreduce is not deployed or this configuration is not set or included in the classpath.

String hbaseClusterDistributedMode = conf.get(QueryServices.HBASE_CLUSTER_DISTRIBUTED_ATTRIB);
        String mapredFrameworkName = conf.get(QueryServices.MAPRED_FRAMEWORK_NAME);
if ((hbaseClusterDistributedMode != null && !hbaseClusterDistributedMode.equals(HBASE_CLUSTER_DISTRIBUTED_CONFIG)) || 
            (mapredFrameworkName != null && !mapredFrameworkName.equals(MAPRED_FRAMEWORK_YARN_CONFIG)))
        {
            LOG.info("Enabling Async Index rebuilder");
            AsyncIndexRebuilderTask asyncIndexRebuilderTask = new AsyncIndexRebuilderTask(e.getEnvironment());
            // run async index rebuilder task every 10 secs to rebuild any newly created async indexes
            executor.scheduleAtFixedRate(asyncIndexRebuilderTask, 10000, rebuildIndexTimeInterval, TimeUnit.MILLISECONDS);
        }

Issue Links

• is related to: PHOENIX-3120 AsyncIndexRebuilderTask fails for transactional tables