[PHOENIX-2937] PHOENIX_QUERYSERVER_OPTS not checked for some options

• Type: Bug
• Status: Reopened
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 4.8.0
• Labels: options

Environment

Phoenix 4.8.0 snapshot

• Assignee: Unassigned
• Reporter: Kevin Liew
• Created: 24/May/16 20:14
• Updated: 03/Jun/16 21:03

Description

Set

PHOENIX_QUERYSERVER_OPTS="-Dphoenix.query.isNamespaceMappingEnabled=true -Dphoenix.queryserver.serialization=JSON

Run

queryserver.py

docker run -e PHOENIX_QUERYSERVER_OPTS="-Dphoenix.queryserver.serialization=JSON" --rm drv-CentOS6-5.woods.ad:5000/phoenix:SNAPSHOT
/
Starting sshd: [  OK  ]
Starting namenodes on [localhost]
localhost: starting namenode, logging to /usr/local/hadoop/logs/hadoop-root-namenode-f8510b471a47.out
localhost: starting datanode, logging to /usr/local/hadoop/logs/hadoop-root-datanode-f8510b471a47.out
Starting secondary namenodes [0.0.0.0]
0.0.0.0: starting secondarynamenode, logging to /usr/local/hadoop/logs/hadoop-root-secondarynamenode-f8510b471a47.out
localhost: starting zookeeper, logging to /usr/local/hbase/bin/../logs/hbase-root-zookeeper-f8510b471a47.out
starting master, logging to /usr/local/hbase/logs/hbase--master-f8510b471a47.out
starting regionserver, logging to /usr/local/hbase/logs/hbase--1-regionserver-f8510b471a47.out
Starting queryserver
16/06/03 20:26:32 INFO server.Main: env:PHOENIX_QUERYSERVER_OPTS=-Dphoenix.queryserver.serialization=JSON
16/06/03 20:26:32 INFO server.Main: env:HADOOP_PREFIX=/usr/local/hadoop
16/06/03 20:26:32 INFO server.Main: env:SHLVL=1
16/06/03 20:26:32 INFO server.Main: env:JAVA_HOME=/usr/java/default
16/06/03 20:26:32 INFO server.Main: env:HBASE_HOME=/usr/local/hbase
16/06/03 20:26:32 INFO server.Main: env:BOOTSTRAP=/etc/bootstrap.sh
16/06/03 20:26:32 INFO server.Main: env:XFILESEARCHPATH=/usr/dt/app-defaults/%L/Dt
16/06/03 20:26:32 INFO server.Main: env:HADOOP_YARN_HOME=/usr/local/hadoop
16/06/03 20:26:32 INFO server.Main: env:PWD=/
16/06/03 20:26:32 INFO server.Main: env:HOSTNAME=f8510b471a47
16/06/03 20:26:32 INFO server.Main: env:YARN_CONF_DIR=/usr/local/hadoop/etc/hadoop
16/06/03 20:26:32 INFO server.Main: env:_=/usr/local/phoenix/bin/queryserver.py
16/06/03 20:26:32 INFO server.Main: env:NLSPATH=/usr/dt/lib/nls/msg/%L/%N.cat
16/06/03 20:26:32 INFO server.Main: env:MAVEN_VERSION=3.3.9
16/06/03 20:26:32 INFO server.Main: env:OLDPWD=/usr/local/hadoop/share/hadoop/common
16/06/03 20:26:32 INFO server.Main: env:HADOOP_COMMON_HOME=/usr/local/hadoop
16/06/03 20:26:32 INFO server.Main: env:ZOO_HOME=/usr/local/zookeeper
16/06/03 20:26:32 INFO server.Main: env:M2_HOME=/usr/local/maven
16/06/03 20:26:32 INFO server.Main: env:PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/java/default/bin:/usr/local/zookeeper/bin:/usr/local/hbase/bin:/usr/local/maven/bin
16/06/03 20:26:32 INFO server.Main: env:PHOENIX_HOME=/usr/local/phoenix
16/06/03 20:26:32 INFO server.Main: env:HADOOP_HDFS_HOME=/usr/local/hadoop
16/06/03 20:26:32 INFO server.Main: env:HOME=/root
16/06/03 20:26:32 INFO server.Main: env:HADOOP_CONF_DIR=/usr/local/hadoop/etc/hadoop
16/06/03 20:26:32 INFO server.Main: env:TZ=GMT-0
16/06/03 20:26:32 INFO server.Main: env:HADOOP_MAPRED_HOME=/usr/local/hadoop
16/06/03 20:26:32 INFO server.Main: vmName=Java HotSpot(TM) 64-Bit Server VM, vmVendor=Oracle Corporation, vmVersion=24.71-b01
16/06/03 20:26:32 INFO server.Main: vmInputArguments=[-Dproc_phoenixserver, -Dlog4j.configuration=file:/usr/local/phoenix-4.8.0-HBase-1.2-SNAPSHOT/bin/log4j.properties, -Dpsql.root.logger=INFO,console, -Dpsql.log.dir=., -Dpsql.log.file=psql.log, -Dphoenix.queryserver.serialization=JSON]
16/06/03 20:26:32 INFO metrics.MetricsSystemLoader: No metrics implementation available on classpath. Using No-op implementation
16/06/03 20:26:32 INFO util.log: Logging initialized @1235ms
16/06/03 20:26:33 INFO server.Main: Instantiated class org.apache.calcite.avatica.server.AvaticaProtobufHandler for QueryServer
16/06/03 20:26:33 INFO server.Server: -9.2.z-SNAPSHOT
16/06/03 20:26:33 INFO server.ServerConnector: Started ServerConnector@688e5f29{HTTP/1.1}{0.0.0.0:8765}
16/06/03 20:26:33 INFO server.Server: Started @1820ms
16/06/03 20:26:33 INFO server.HttpServer: Service listening on port 8765.

Verify that the options were set in `vmInputArguments` of the log file.

16/06/03 20:26:32 INFO server.Main: vmInputArguments=[-Dproc_phoenixserver, -Dlog4j.configuration=file:/usr/local/phoenix-4.8.0-HBase-1.2-SNAPSHOT/bin/log4j.properties, -Dpsql.root.logger=INFO,console, -Dpsql.log.dir=., -Dpsql.log.file=psql.log, -Dphoenix.queryserver.serialization=JSON]
...
16/06/03 20:26:33 INFO server.Main: Instantiated class org.apache.calcite.avatica.server.AvaticaProtobufHandler for QueryServer

The psql log options work because the log file is created (when using `queryserver.py start` instead of logging to the foreground), but the options that were set above do not take effect. The server logs `-Dphoenix.queryserver.serialization=JSON` but still uses PROTOBUF instead of JSON.