Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-1731

Add getNextIndexedKey() to IndexHalfStoreFileReader and FilteredKeyValueScanner

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.2.3, 4.3.1
    • Fix Version/s: 4.3.1, 4.4.0
    • Labels:
      None

      Description

      See HBASE-13109, which changes two private interfaces, which breaks Phoenix compilation, which uses these interfaces.

      On the jira we decided not to remove those changes (that's why they're marked private).

      But, we can easily fix this in Phoenix by adding these methods to the classes that cause the problem, being care not to add the override annotation. The method can safely return null, in which case the optimization will not be used when these classes are used.

      1. 1731.txt
        2 kB
        Lars Hofhansl

        Issue Links

          Activity

          Hide
          lhofhansl Lars Hofhansl added a comment -

          Trivial fix. I'd suggest to put this in the 4.2, 4.3, and 5.0 code lines.

          Show
          lhofhansl Lars Hofhansl added a comment - Trivial fix. I'd suggest to put this in the 4.2, 4.3, and 5.0 code lines.
          Hide
          lhofhansl Lars Hofhansl added a comment -

          Looking forward, let's also work out how we can avoid this in the future. Maybe in HBase 1.1 we can add super classes for these typed of classes in order to allow default implementations (as suggested by James Taylor on HBASE-13109).

          Show
          lhofhansl Lars Hofhansl added a comment - Looking forward, let's also work out how we can avoid this in the future. Maybe in HBase 1.1 we can add super classes for these typed of classes in order to allow default implementations (as suggested by James Taylor on HBASE-13109 ).
          Hide
          jamestaylor James Taylor added a comment -

          +1 on the patch and on adding base classes for 1.1.

          Show
          jamestaylor James Taylor added a comment - +1 on the patch and on adding base classes for 1.1.
          Hide
          rajeshbabu Rajeshbabu Chintaguntla added a comment -

          +1. Thanks Lars.

          Show
          rajeshbabu Rajeshbabu Chintaguntla added a comment - +1. Thanks Lars.
          Hide
          lhofhansl Lars Hofhansl added a comment -

          Thanks for taking a look. Going to commit to 4.2.x+

          Show
          lhofhansl Lars Hofhansl added a comment - Thanks for taking a look. Going to commit to 4.2.x+
          Hide
          lhofhansl Lars Hofhansl added a comment -

          Pushed to master, 4.0, 4.3, and 4.2.
          I'll file a task now for the abstract classes in HBase.

          Show
          lhofhansl Lars Hofhansl added a comment - Pushed to master, 4.0, 4.3, and 4.2. I'll file a task now for the abstract classes in HBase.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Phoenix-master #615 (See https://builds.apache.org/job/Phoenix-master/615/)
          PHOENIX-1731 Add getNextIndexedKey() to IndexHalfStoreFileReader and FilteredKeyValueScanner. (larsh: rev 66fb38cade511d3544a748eb1a2c9da446cf2984)

          • phoenix-core/src/main/java/org/apache/phoenix/hbase/index/scanner/FilteredKeyValueScanner.java
          • phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReader.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Phoenix-master #615 (See https://builds.apache.org/job/Phoenix-master/615/ ) PHOENIX-1731 Add getNextIndexedKey() to IndexHalfStoreFileReader and FilteredKeyValueScanner. (larsh: rev 66fb38cade511d3544a748eb1a2c9da446cf2984) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/scanner/FilteredKeyValueScanner.java phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReader.java
          Hide
          enis Enis Soztutar added a comment -

          This seems committed. Lars Hofhansl do you mind resolving?

          Show
          enis Enis Soztutar added a comment - This seems committed. Lars Hofhansl do you mind resolving?
          Hide
          jamestaylor James Taylor added a comment -

          Resolving this for Lars

          Show
          jamestaylor James Taylor added a comment - Resolving this for Lars
          Hide
          enis Enis Soztutar added a comment -

          Bulk close of all issues that has been resolved in a released version.

          Show
          enis Enis Soztutar added a comment - Bulk close of all issues that has been resolved in a released version.

            People

            • Assignee:
              lhofhansl Lars Hofhansl
              Reporter:
              lhofhansl Lars Hofhansl
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development