Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-1676

Set priority of Index Updates correctly

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 4.0.0, 4.3.1
    • 4.3.1, 4.4.0
    • None
    • None

    Description

      I spoke to Jesse offline about this.

      The priority of index updates isn't being set correctly because of the use of CoprocessorHConnection (which all coprocessors use if they create an HTable via the CPEnvironment).

      Specifically the flow happens like this: the CoprocessorHTableFactory attempts to set the connection qos factory, but it is ignored because the CoprocessorHConnection is used (instead of a standard HConnection) and the #getClient method just goes straight into the rpc scheduler of the HRegionServer, if its on the same server. This allows the region to be directly accessed, but without actually going over the loopback or serializing any information.

      However, this means it ignores the configured rpccontroller factory and the override setting of the rpc priority. We probably shouldn't be runtime changing the configuration - instead we should probably be using some other serialized information.

      The primary fix would seems to be that the regionserver needs to be configured with the IndexQosRpcControllerFactory and then use a static map (or cache of the index metadata) to set the qos for the index servers.

      Attachments

        1. PHOENIX-1676-4.x-HBase-0.98.patch
          23 kB
          Thomas D'Silva
        2. PHOENIX-1676-4.x-HBase-1.x.patch
          22 kB
          Thomas D'Silva
        3. PHOENIX-1676-4.x-HBase-0.98-v2.patch
          25 kB
          Thomas D'Silva
        4. PHOENIX-1676-4.x-HBase-1.x-v2.patch
          25 kB
          Thomas D'Silva
        5. PHOENIX-1676-4.3.patch
          25 kB
          Thomas D'Silva

        Issue Links

          Activity

            People

              tdsilva Thomas D'Silva
              tdsilva Thomas D'Silva
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: