[PHOENIX-1472] SaltingUtil calculates wrong salt key for Integer.MIN_VALUE hash code

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.3.0, 3.3.0, 3.2.2, 4.2.2
• Assignee: Gabriel Reid
• Reporter: Gabriel Reid
• Created: 20/Nov/14 15:12
• Updated: 21/Nov/15 02:16
• Resolved: 26/Nov/14 19:44

Description

There is an edge case in SaltingUtil.getSaltingByte where an invalid salt byte is calculated. This happens when the hash code of the row key being salted is equal to Integer.MIN_VALUE. The underlying bug is the use of Math.abs(hashCode) in SaltingUtil.getSaltingByte, and the result of the bug is that a hash code outside of the range of configured salt buckets can be returned.