[PHOENIX-1060] Replace ReferencingColumn with ColumnReference

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.4.0
• Assignee: Rajeshbabu Chintaguntla
• Reporter: rajeshbabu
• Created: 04/Jul/14 09:35
• Updated: 21/Nov/15 02:17
• Resolved: 08/Mar/15 07:01

Description

We currently have two separate classes that represent a column family/column qualifier combo: ColumnReference and ReferencingColumn. I believe the only difference is that ReferencingColumn allows a backing byte array to be used with an offset and length. Since ColumnReference already has an ImmutableBytesPtr we can add a constructor that takes two offsets and lengths for the family and qualifier and do a bit of minor refactoring (removing the family and qualifier member variables and just use the familyPtr and qualifierPtr ones exclusivly) so that we don't have two classes for the same thing:

public class ColumnReference implements Comparable<ColumnReference> {
    
  public ColumnReference(byte[] family, int familyOffset, int familyLength, byte[] qualifier, int qualifierOffset, int qualiferLength) {
    this.familyPtr = new ImmutableBytesPtr(family, familyOffset, familyLength);
    this.qualifierPtr = new ImmutableBytesPtr(qualifier, qualifierOffset, qualifierLength);
    this.hashCode = calcHashCode(familyPtr.get(), qualifierPtr.get());
  }

Another useful addition would be to implement Writable so we don't duplicate the serialization logic.

Issue Links

• is a clone of: PHOENIX-1058 Support index region split on it's corresponding data region split
• is cloned by: PHOENIX-1084 Use same split logic for intra region splits over local indexes