[PDFBOX-5863] bad comparison of byte with 128

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.2 PDFBox
• Fix Version/s: 3.0.3 PDFBox, 4.0.0
• Component/s: PDModel
• Assignee: Tilman Hausherr
• Reporter: Dieter von Holten
• Created: 04/Aug/24 16:33
• Updated: 11/Aug/24 08:30
• Resolved: 05/Aug/24 13:00

Description

inspection by spotbugs shows a problem in o.a.padfbox.pdmodel.font.FontFactory line 285:

the partial expression header[0] == 0x80 && ...

is always false. The code should be{{ header[0] == (byte) 0x80 && ...}}