[PDFBOX-5814] Limit overwrite warning to non empty files

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.2 PDFBox
• Fix Version/s: 3.0.3 PDFBox, 4.0.0
• Component/s: Writing
• Assignee: Tilman Hausherr
• Reporter: Tilman Hausherr
• Created: 06/May/24 12:19
• Updated: 10/Aug/24 07:18
• Resolved: 06/May/24 12:22

Description

As written by Anthony Brunellière on the dev mailing list:

The method PDDocument.save(..) (version 3.0.2) generates a warning if the output file already exists :
{code:java}
public void save(File file, CompressParameters compressParameters) throws IOException
    {
        if (file.exists())
        {
            LOG.warn(
                    "You are overwriting the existing file " + file.getName()
                            + ", this will produce a corrupted file if you're also reading from it");
        }

I understand the disclaimer "Don't use the input file as target as this will produce a corrupted file", but I'm in a context where an empty ouput file is created just before for specific reasons.

Should this warning be limited to non-empty files?