[PDFBOX-5534] Remove finalize from ScratchFileBuffer

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.27, 3.0.0 PDFBox
• Fix Version/s: 2.0.28, 3.0.0 PDFBox
• Component/s: Parsing
• Assignee: Andreas Lehmkühler
• Reporter: Andreas Lehmkühler
• Created: 26/Oct/22 20:21
• Updated: 13/Apr/23 14:54
• Resolved: 01/Nov/22 14:08

Description

The usage of finalize is discouraged so that it is a good idea to remove it.

I've found a way to do so for ScratchFileBuffer. All created buffers are collected within ScratchFile. Once a buffer is closed it is removed from the collection. If ScratchFile is closed when closing the pdf all remaining buffers are closed as well.

Issue Links

• is related to: PDFBOX-5362 [PATCH] Replace finalize() with Cleaner