[PDFBOX-5523] Bug in org/apache/pdfbox/multipdf/Overlay#overlay(specificPageOverlayFile)

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.0.27, 3.0.0 PDFBox
• Fix Version/s: 2.0.28, 3.0.0 PDFBox
• Labels: Overlay regression
• Assignee: Tilman Hausherr
• Reporter: Stefan Ziegler
• Created: 07/Oct/22 10:14
• Updated: 15/Jan/24 08:28
• Resolved: 08/Oct/22 02:49

Description

path = e.getValue();
LayoutPage layoutPage = layouts.get(path);
if (layoutPage == null)
{
    PDDocument doc = loadPDF(path);
    layouts.put(path, getLayoutPage(doc));
    openDocuments.add(doc);
}
specificPageOverlayPage.put(e.getKey(), layoutPage);

layoutPage is null because never assigned within the if clause. It should be:

path = e.getValue();
LayoutPage layoutPage = layouts.get(path);
if (layoutPage == null)
{
    PDDocument doc = loadPDF(path);
    openDocuments.add(doc);
    layoutPage = getLayoutPage(doc);
    layouts.put(path, layoutPage);
}
specificPageOverlayPage.put(e.getKey(), layoutPage);

Issue Links

• breaks: PDFBOX-5748 Cannot get overlayPDF working on command line interface
• duplicates: PDFBOX-5527 The pages option does not work correctly for the overlay command