[PDFBOX-5298] unneeded / double code in PageExtractor

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.24
• Fix Version/s: 2.0.25, 3.0.0 PDFBox
• Component/s: Utilities
• Assignee: Tilman Hausherr
• Reporter: Tilman Hausherr
• Created: 20/Oct/21 17:53
• Updated: 17/Dec/21 06:50
• Resolved: 20/Oct/21 17:59

Description

valerybokov mentioned this in PR 107:

I found one strange detail in a PageExtractor class. An interesting process is going on inside the extraction method. In the loop we calling the importPage method. Inside this method we changing the cropbox, mediabox and rotation for an imported page. We doeing the same in the PageExtractor.extract method. Maybe you will remove unneeded initialisations of the cropbox etc. Also, the importPage method notifies us about resources but we doeing right operation with resources in the PageExtractor.extract method (inherited resources of source document are not imported to...).

I'll remove the calls and make the resource setting conditional as suggested in ImportPage.