[PDFBOX-5224] Optimize SampledImageReader.from1Bit()

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.24
• Fix Version/s: 2.0.25, 3.0.0 PDFBox
• Component/s: Rendering
• Labels: optimization
• Assignee: Tilman Hausherr
• Reporter: Tilman Hausherr
• Created: 24/Jun/21 03:14
• Updated: 17/Dec/21 06:50
• Resolved: 24/Jun/21 03:34

Description

From Gunnar Brand:

This fixes an issue with a missed logged error + loop breaking if an erroneous read falls onto a skipped row.

It also improves the speed at least by factor twice (due to sign test instead of bit masking and boolean flag for subsampling).
It will be even faster with regions, as there was a poor design choice of full inner loop computations even if x was below startX.

Attached: page 1 of https://archive.org/details/AlfaWaffenkatalog1911

Issue Links

• links to: Update SampledImageReader.java #122