[PDFBOX-5199] Possible memory leak after calling decode filter

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.23
• Fix Version/s: 2.0.24, 3.0.0 PDFBox
• Assignee: Tilman Hausherr
• Reporter: Tilman Hausherr
• Created: 22/May/21 13:25
• Updated: 11/Jun/21 06:08
• Resolved: 22/May/21 14:57

Description

valerybokov noticed in PR#107 that filters are sometimes closed and sometimes not

IdentityFilter and CCITTFaxFilter extends Filter
IdentityFilter.encode(InputStream, OutputStream, COSDictionary). The InputStream will not be closed.
CCITTFaxFilter.encode(InputStream, OutputStream, COSDictionary). The InputStream will be closed.
The input parameter will not be closed if an exception is thrown.

My understanding is that the caller should close streams unless the javadoc tell something else. So I did search a bit, and found places in COSStream and PDStream where this isn't done. Any close in filter should be removed.

I also searched for encode but there I found that the caller closes properly.