[PDFBOX-4882] Two conditions are always false in TrueTypeEmbedder.isEmbeddingPermitted

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.20
• Fix Version/s: 2.0.21, 3.0.0 PDFBox
• Assignee: Tilman Hausherr
• Reporter: Alfred
• Created: 14/Jun/20 09:57
• Updated: 11/May/21 16:48
• Resolved: 28/Jun/20 07:56

Description

 

IntelliJ says the 2 conditions bellow are always false in TrueTypeEmbedder

private boolean isEmbeddingPermitted(TrueTypeFont ttf) throws IOException
{
    if (ttf.getOS2Windows() != null)
    {
        int fsType = ttf.getOS2Windows().getFsType();
        int exclusive = fsType & 0x8; // bits 0-3 are a set of exclusive bits

        if ((exclusive & OS2WindowsMetricsTable.FSTYPE_RESTRICTED) ==
                         OS2WindowsMetricsTable.FSTYPE_RESTRICTED)
        {
            // restricted License embedding
            return false;
        }
        else if ((exclusive & OS2WindowsMetricsTable.FSTYPE_BITMAP_ONLY) ==
                             OS2WindowsMetricsTable.FSTYPE_BITMAP_ONLY)
        {
            // bitmap embedding only
            return false;
        }
    }
    return true;
}

Can this be a bug?

 

Issue Links

• causes: PDFBOX-5191 isEmbeddingPermitted() is too restrictive on TTFs with OS2 table versions 0-2
• relates to: PDFBOX-2524 [PATCH] Two PDFont to create PDF documents in CJK and non-ISO-8859-1 languages
• links to: fstype in OS2 table