[PDFBOX-4504] Warnings when structure tree RoleMap is merged if the key is already existing in destination directory

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.14
• Fix Version/s: 2.0.15, 3.0.0 PDFBox
• Component/s: Utilities
• Assignee: Tilman Hausherr
• Reporter: Stephan Merkli
• Created: 02/Apr/19 19:57
• Updated: 12/Apr/19 14:39
• Resolved: 03/Apr/19 03:59

Description

In https://issues.apache.org/jira/browse/PDFBOX-4415 the feature to merge the RoleMap was introduced.

In PDFMergerUtility#mergeRoleMap a warning is logged whenever the destination dictionary contains a key from the source directory.

Not completely sure, but wouldn't it be better to only log a warning when the values are different?

When merging twice the same template (e.g. with some form fields filled), a warning is logged currently because both templates contains the same role maps.

 

Best regards and thanks in advance

Stephan