[PDFBOX-3999] Merge failed to clone tags

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.0.8
• Fix Version/s: 2.0.10, 3.0.0 PDFBox
• Component/s: Utilities
• Labels: StructureTree merge
• Flags: Patch
• Assignee: Tilman Hausherr
• Reporter: Dave Hill
• Created: 08/Nov/17 18:38
• Updated: 21/Jun/18 20:27
• Resolved: 20/Apr/18 15:38

Description

After merging two tagged documents, closing the source document causes the destination document to be closed, which prevents it from being saved. The following code demonstrates the bug with the attached flattened government PDF file. The original is available here if you need it.

@Test
public void testMerge() throws Exception {
    PDFMergerUtility pdfMergerUtility = new PDFMergerUtility();
    PDDocument src = PDDocument.load(new File("GovFormPreFlattened.pdf"));
    PDDocument dest = PDDocument.load(new File("GovFormPreFlattened.pdf"));
    pdfMergerUtility.appendDocument(dest, src);
    src.close(); //if we don't close the src then we don't have an error
    dest.save(File.createTempFile("MergeIssue",".PDF"));
    dest.close();
}

The issue is resolved with the attached patch.

Also I removed the "if (mergeStructTree)" is because mergeStructTree is always true here because this code is already inside an "if (mergeStructTree)".

Issue Links

• is broken by: PDFBOX-4004 Elements in the structure tree are not removed or corrected when flattening
• links to: Files flattened and merged with PDFBox are sharing common COSStream