[PDFBOX-3854] PDDeviceRGB.toRGBImage should return a RGB-Typed-Image

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.6
• Fix Version/s: 2.0.7, 3.0.0 PDFBox
• Component/s: PDModel, Rendering
• Labels: optimization
• Assignee: Tilman Hausherr
• Reporter: Yannick Haser
• Created: 04/Jul/17 09:45
• Updated: 21/Jul/17 04:40
• Resolved: 08/Jul/17 11:12

Description

While converting a PDPage to a BufferedImage (using the PDFRenderer) Images-Resources located in the PDPage gets loaded in a WriteableRaster and a given Colorspace.

These get converted to a BufferedImage (with PDDeviceRGB.toRGBImage()). But the Type of the returing BufferedImage is with the given Raster and Colorspace always from Type "BufferedImage.TYPE_CUSTOM" instead of the expected "BufferedImage.TYPE_INT_RGB" for example.

Consequences:
Image-Processing-Operations with/on BufferedImages with TYPE_CUSTOM are not optimized in Java (slower) and partialy runs through "Synchronized" Blocks.
==> Converting different Documents in different Threads are blocking each other.

"Quick"-Fix for seeing a Performance-Improvement in a Multithreading Environment:

PDDeviceRGB.java

@Override
public BufferedImage toRGBImage(WritableRaster raster) throws IOException {
	init();
	ColorModel colorModel = new ComponentColorModel(awtColorSpace, false, false, Transparency.OPAQUE,
			raster.getDataBuffer().getDataType());

	BufferedImage image = new BufferedImage(colorModel, raster, false, null);

	BufferedImage dest = new BufferedImage(image.getWidth(), image.getHeight(), BufferedImage.TYPE_INT_RGB);
	ColorConvertOp op = new ColorConvertOp(dest.getColorModel().getColorSpace(), null);
	return op.filter(image, dest);
}

Issue Links

• is related to: PDFBOX-3860 TilingPaint.getImage() should return an ARGB-Typed-Image