[PDFBOX-3417] Redundant/incorrect code in PDVisibleSignDesigner.java

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.0.2, 2.0.3, 3.0.0 PDFBox
• Fix Version/s: 2.0.3, 3.0.0 PDFBox
• Component/s: PDModel
• Assignee: Tilman Hausherr
• Reporter: Vittal Aithal
• Created: 12/Jul/16 10:57
• Updated: 25/Mar/17 18:13
• Resolved: 18/Jul/16 19:04

Description

org/apache/pdfbox/pdmodel/interactive/digitalsignature/visible/PDVisibleSignDesigner.java contains the following in the calculatePageSize method:

    float x = pageWidth;
    float y = 0;
    pageWidth += y;
    float tPercent = (100 * y / (x + y));
    imageSizeInPercents = 100 - tPercent;

I can't see how this would result in anything but an imageSizeInPercents of 100.