[PDFBOX-2783] Remove getCOSDictionary() method, adjust getCOSObject() return type

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Assignee: Unassigned
• Reporter: Tilman Hausherr
• Created: 01/May/15 11:17
• Updated: 17/Mar/16 19:07
• Resolved: 16/May/15 11:24

Description

As discussed on the mailing list: Remove getCOSDictionary(), use getCOSObject() instead, change return type to COSDictionary or whatever is applicable. If possible, change javadoc too.

While working on it, I noticed code like this:

        if (newDomain == null)
        {
            getCOSDictionary().removeItem(COSName.DOMAIN);
        }
        else
        {
            getCOSDictionary().setItem(COSName.DOMAIN, newDomain);
        }

this should be replaced with

        getCOSObject().setItem(COSName.DOMAIN, newDomain);

because setItem() calls removeItem() when the second parameter is nulll.