[PDFBOX-2769] NPE when saving encrypted file

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.9, 1.8.10, 2.0.0
• Fix Version/s: 1.8.10, 2.0.0
• Component/s: Crypto, Writing
• External issue URL: http://www.optionsclearing.com/market-data/series/ess-record-layout.pdf
• Assignee: Tilman Hausherr
• Reporter: Tilman Hausherr
• Created: 22/Apr/15 05:38
• Updated: 23/Jul/15 06:35
• Resolved: 22/Apr/15 18:40

Description

Mailing list user gets this when loading and then saving an encrypted file (of which he didn't know it was encrypted):

java.lang.NullPointerException
    at org.apache.pdfbox.pdmodel.encryption.StandardSecurityHandler.computeRevisionNumber(StandardSecurityHandler.java:129)
    at org.apache.pdfbox.pdmodel.encryption.StandardSecurityHandler.prepareDocumentForEncryption(StandardSecurityHandler.java:332)
    at org.apache.pdfbox.pdfwriter.COSWriter.write(COSWriter.java:1254)
    at org.apache.pdfbox.pdfwriter.COSWriter.write(COSWriter.java:1215)
    at org.apache.pdfbox.pdmodel.PDDocument.save(PDDocument.java:958)
    at org.apache.pdfbox.pdmodel.PDDocument.save(PDDocument.java:930) 

At the very least, we should bring an IllegalStateException with a useful message telling what to do.