[PDFBOX-2490] Return value of COSDocument#isEncrypted is unclear

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.7, 2.0.0
• Fix Version/s: 1.8.8, 2.0.0
• Component/s: Parsing, PDModel
• Labels: Encryption
• Assignee: Andreas Lehmkühler
• Reporter: Andreas Lehmkühler
• Created: 08/Nov/14 13:12
• Updated: 13/Dec/14 14:15
• Resolved: 08/Nov/14 14:02

Description

According to the java doc COSDocument#isEncrypted provides if a pdf is encrypted or not. But it's not clear what it really means:

• is the pdf somehow encrypted
• is an encrypted pdf already decrypted after parsing

I guess the first case was the origin intention of this method. Although a comment in the code indicates that the information is needed within the non-sequential parser I can't find any call of COSDocument#isEncrypted anywhere in the non-sequential parser.

I'm going to change the behaviour of isEncrypted so that it follows the origin intention and I'll add a new method isDecrypted as well.

Issue Links

• relates to: TIKA-1467 pdf:encrypted:false with encrypted pdf