[PDFBOX-1991] Shading PaintContexts should not depend on the page height

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Component/s: Rendering
• Labels: shading shadingpattern
• Assignee: Unassigned
• Reporter: John Hewson
• Created: 19/Mar/14 03:08
• Updated: 17/Mar/16 19:07
• Resolved: 01/Sep/14 18:42

Description

I'd like to remove the page height parameter from PDPattern as soon as possible because of doubts over its safety (i.e. the current stream being processed may be a pattern or a form, not a page). Before I do that we need to remove its only use, which is...

The page height is passed to all shading PaintContext subclasses but it is only used in GouraudShadingContext. However, all other drawing in PDFBox is done using the native PDF y-axis which is flipped via a call to Graphics2D#scale(0, -1) but the following code in GouraudShadingContext flips the y-axis:

v.point = new Point.Double(v.point.getX(), pageHeight + xform.getTranslateY() - v.point.getY());

So it seems like this could be removed and the y-axis inversion done elsewhere with either a Matrix, AffineTransform or Grpahics2D#scale.

Issue Links

• relates to: PDFBOX-2171 UnsupportedOperationException for stencil image / pattern