[PDFBOX-1583] wasted work in PDDocument.addSignature(...)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.1
• Fix Version/s: 1.8.2
• Labels: patch
• Assignee: Andreas Lehmkühler
• Reporter: Adrian Nistor
• Created: 28/Apr/13 16:29
• Updated: 02/Jun/13 13:35
• Resolved: 28/Apr/13 16:50

Description

The problem appears in version 1.8.1 and in revision 1476791. I
attached a one-line patch that fixes it. This problem is similar to
the already fixed PDFBOX-1447 and PDFBOX-1457.

In method "PDDocument.addSignature", the loop over "cosObjects" should
break immediately after "annotNotFound" and "sigFieldNotFound" are set
to "false". All the iterations after "annotNotFound" and
"sigFieldNotFound" are set to "false" do not perform any useful work
because the two "if" statements performing useful work depend on
"annotNotFound" and "sigFieldNotFound".