[PB-84] CCE in PortletWindowUtils.getPortletWindowId

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 1.0
• Component/s: common
• Environment: Mac OS, Wicket Portlets, OpenPortal Portlet Container
• Assignee: Unassigned
• Reporter: Tim Boudreau
• Created: 16/Aug/08 09:43
• Updated: 14/Sep/11 12:10
• Resolved: 14/Sep/11 12:10

Description

I'm trying to get wicket portlet support working over OpenPortal. I've hacked together implementations of ServletContextProvider and PortletResourceURLFactory - just required exposing WicketFilter from the Application to get the necessary data. I can deploy a portlet, but...

I'm getting this exception.

java.lang.ClassCastException: java.lang.Double
at org.apache.portals.bridges.util.PortletWindowUtils.getPortletWindowId(PortletWindowUtils.java:45)

Looking at the code, this seems like a clear bug: The method casts to String here:
(String)session.getAttribute(PORTLET_WINDOW_ID);

and if null fills in the value with an instance of Double. If it's going to put a Double there, it should probably not expect a String - this exception will occur any time this method is called twice for a PortletSession, it will throw the CCE the second time it is called.

Since the value is not used, probably simply changing it to
Object portletWindowId = session.getAttribute(PORTLET_WINDOW_ID);

would fix it.

Issue Links

• duplicates: PB-77 Cannot cast Double to String