Uploaded image for project: 'Parquet'
  1. Parquet
  2. PARQUET-528

Fix flush() for RecordConsumer and implementations

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.0, 1.8.1
    • Fix Version/s: 1.9.0, 1.8.2
    • Component/s: parquet-mr
    • Labels:
      None

      Description

      flush() was added in RecordConsumer and MessageColumnIO to help implementing nulls caching.

      However, other RecordConsumer implementations should also implements flush() properly. For instance, RecordConsumerLoggingWrapper and ValidatingRecordConsumer should call delegate.flush() in their flush() methods, otherwise data might be mistakenly truncated.

      This ticket:

      • makes flush() abstract in RecordConsumer
      • implements flush() properly for all RecordConsumer subclasses, specifically:
        • RecordConsumerLoggingWrapper
        • ValidatingRecordConsumer
        • ConverterConsumer
        • ExpectationValidatingRecordConsumer

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                proflin Liwei Lin(Inactive)
                Reporter:
                proflin Liwei Lin(Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: