[PARQUET-412] Format: Do not shade slf4j-api

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: format-2.4.0
• Component/s: parquet-format
• Assignee: Julien Le Dem
• Reporter: Ryan Blue
• Created: 18/Dec/15 17:36
• Updated: 23/Jun/24 03:27
• Resolved: 10/Oct/17 20:51

Description

PARQUET-369 fixed warnings from shading slf4j-api, but a consequence of shading is that the log messages from thrift for parquet-format classes are dropped. This was an accepted trade-off until PARQUET-305 changed logging in the rest of the library to SLF4J. Now that the slf4j-api is a dependency for all of Parquet except parquet-format, it no longer makes sense to suppress the format thrift logs to avoid exposing it.

This also requires PARQUET-371 because thrift 0.7.0 relies on a very old version of slf4j-api.

Issue Links

• blocks: PARQUET-1134 Release Parquet format 2.4.0
• is related to: PARQUET-369 Shading SLF4J prevents SLF4J locating org.slf4j.impl.StaticLoggerBinder
• is related to: PARQUET-305 Logger instantiated for package org.apache.parquet may be GC-ed
• is required by: PARQUET-408 Shutdown hook in parquet-avro library corrupts data and disables logging
• requires: PARQUET-371 Bumps Thrift version to 0.9.3
• links to: PR #50