Uploaded image for project: 'Parquet'
  1. Parquet
  2. PARQUET-2131

Number values decoded DCHECKs should be exceptions

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      As discussed on some other bugs, there are some parquet-cpp DCHECKs on the number of values decoded that really should be exceptions. When invalid Parquet files are read, it is possible for the decoders to return less values than expected and this should be signaled back to the user even in non-debug mode and it should not be a crash in debug mode. A fuzzer I have been running managed to create two examples that crashed parquet-cpp due to the DCHECKs. These don't currently crash the non-arrow cpp interfaces for reading parquet but we might consider making those methods also throw exceptions in these situations.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            willb_google William Butler
            willb_google William Butler
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 2h 20m
                2h 20m

                Slack

                  Issue deployment