[PARQUET-1384] [C++] Clang compiler warnings in bloom_filter-test.cc

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: cpp-1.5.0
• Component/s: parquet-cpp
• Labels: pull-request-available
• Assignee: Junjie Chen
• Reporter: Wes McKinney
• Created: 16/Aug/18 23:03
• Updated: 23/Jun/24 03:30
• Resolved: 17/Aug/18 16:56

Description

[69/95] Building CXX object src/parquet/CMakeFiles/bloom_filter-test.dir/bloom_filter-test.cc.o
../src/parquet/bloom_filter-test.cc:75:36: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
  BlockSplitBloomFilter de_bloom = std::move(BlockSplitBloomFilter::Deserialize(&source));
                                   ^
../src/parquet/bloom_filter-test.cc:75:36: note: remove std::move call here
  BlockSplitBloomFilter de_bloom = std::move(BlockSplitBloomFilter::Deserialize(&source));
                                   ^~~~~~~~~~                                           ~
../src/parquet/bloom_filter-test.cc:168:7: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
      std::move(BlockSplitBloomFilter::Deserialize(&source));
      ^
../src/parquet/bloom_filter-test.cc:168:7: note: remove std::move call here
      std::move(BlockSplitBloomFilter::Deserialize(&source));
      ^~~~~~~~~~                                           ~
../src/parquet/bloom_filter-test.cc:164:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
  handle->Read(size, &buffer);
  ^~~~~~~~~~~~ ~~~~~~~~~~~~~
../src/parquet/bloom_filter-test.cc:192:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
  handle->Seek(0);
  ^~~~~~~~~~~~ ~
../src/parquet/bloom_filter-test.cc:193:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
  handle->GetSize(&size);
  ^~~~~~~~~~~~~~~ ~~~~~
../src/parquet/bloom_filter-test.cc:195:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
  handle->Read(size, &buffer2);

Issue Links

• links to: GitHub Pull Request #488
• links to: GitHub Pull Request #490