[PARQUET-1333] [C++] Reading of files with dictionary size 0 fails on Windows with bad_alloc

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: cpp-1.4.0
• Fix Version/s: cpp-1.5.0
• Component/s: parquet-cpp

Environment

Microsoft Windows 10 Pro with latest arrow master.

• Assignee: Unassigned
• Reporter: Philipp Hoch
• Created: 22/Jun/18 06:44
• Updated: 28/Jun/18 15:27
• Resolved: 28/Jun/18 15:27

Description

Account for total_size being 0, having no dictionary entries to allocate for.

The call with size 0 ends up in arrows memory_pool, https://github.com/apache/arrow/blob/884474ca5ca1b8da55c0b23eb7cb784c2cd9bdb4/cpp/src/arrow/memory_pool.cc#L50, and the according allocation fails. See according documentation, https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/aligned-malloc. Only happens on Windows environment, as posix_memalign seems to handle 0 inputs in unix environments.