Uploaded image for project: 'Parquet'
  1. Parquet
  2. PARQUET-1319

[C++] Pass BISON_EXECUTABLE to Thrift EP for MacOS

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: cpp-1.5.0
    • Component/s: parquet-thrift
    • Labels:
      None
    • Environment:

      Mac mini (High Sierra 10.13.4)

      Description

      I was building parquet-cpp on my Mac mini (High Sierra 10.13.4). I've got an error:

      /Users/sdkteam/jenkins/workspace/Dev-Mac/src/ThirdParty/parquet-cpp/build/thrift_ep-prefix/src/thrift_ep/compiler/cpp/src/thrift/thrifty.yy:1.1-5: invalid directive: `%code'
      /Users/sdkteam/jenkins/workspace/Dev-Mac/src/ThirdParty/parquet-cpp/build/thrift_ep-prefix/src/thrift_ep/compiler/cpp/src/thrift/thrifty.yy:1.7-14: syntax error, unexpected identifier
      make[5]: *** [compiler/cpp/thrift/thrifty.cc] Error 1
      make[4]: *** [compiler/cpp/CMakeFiles/parse.dir/all] Error 2
      make[3]: *** [all] Error 2
      

      I googled and they said that I need to upgrade bison to 3.0. I did and did every way I can to config $PATH and successfully change: on terminal "bison --version" printed 3.0.5

      Somehow cmake still recognize old bison in /usr/bin/bison.

      I tried to add BISON_EXECUTABLE=/usr/local/Cellar/bison/3.0.5/bin/bison into THRIFT_CMAKE_ARGS in /cmake_modules/ThirdpartyToolchain.cmake  and it works.

      I think it should be helpful if I can pass BISON_EXECUTABLE from parquet-cpp to thrift ep. Can you please help that or suggest me another way?

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                thamha Tham
                Reporter:
                thamha Tham
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: