[PARQUET-1279] Use ASSERT_NO_FATAIL_FAILURE in C++ unit tests

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: cpp-1.5.0
• Component/s: parquet-cpp
• Labels: pull-request-available
• Assignee: Joshua Storck
• Reporter: Joshua Storck
• Created: 23/Apr/18 15:15
• Updated: 23/Jun/24 03:30
• Resolved: 23/Apr/18 20:51

Description

A number of unit tests have helper functions that use gtest/arrow ASSERT_ macros. Those ASSERT_ macros simply return out of the current context and do not throw exceptions or abort. Since these helper functions return void, the unit test simply continues when the assertions are triggered. This can lead to additional failures, such as segfaults because the test is executing code that it did not expect to. By adding the gtest ASSERT_NO_FATAIL_FAILURE to the calls of those helper functions in the outermost scope of the unit test, the test will correctly terminate.

Issue Links

• links to: GitHub Pull Request #458