[PARQUET-1040] Missing writer method implementations

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: cpp-1.2.0
• Component/s: parquet-cpp
• Assignee: Uwe Korn
• Reporter: Toby Shaw
• Created: 23/Jun/17 08:18
• Updated: 05/Jul/17 21:59
• Resolved: 05/Jul/17 21:59

Description

In file/writer.h, these methods exist:

For RowGroupWriter:
num_rows
num_columns

For ParquetFileWriter:
num_rows
num_row_groups
num_columns

When using these methods, I get link errors:

LNK2028 unresolved token (0A001B98) "public: int __cdecl parquet::ParquetFileWriter::num_row_groups(void)const " (?num_row_groups@ParquetFileWriter@parquet@@$$FQEBAHXZ) referenced in ...

Looking in the source, it's because these methods are not implemented in writer.cc. This should be a trivial fix.