[OWB-861] Decorator building fails when decorator has inheritance

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.8
• Fix Version/s: 1.1.8, 1.2.0
• Component/s: Interceptor and Decorators
• Labels: decorator openejb
• Assignee: Romain Manni-Bucau
• Reporter: Thomas Herzog
• Created: 13/May/13 06:59
• Updated: 15/May/13 05:55
• Resolved: 15/May/13 05:55

Description

When there is a decorator which inherits from a base implementation.

BaseDecorator - BaseModuleDecorator - ServiceDecorator(abstract) where the ServiceDecorator injects the delegate.
It does not matter if the BaseDecorator or BaseModuleDecorator are abstract or not.
The base decorators hold common resources for the concrete decorator implementation.

The BaseDecorator is not removed from the 'decoratedTypes - set' but the BaseModuleDecorator is.

This happens in org.apache.webbeans.component.creation.DecoratorBeanBuilder#defineDecoratedTypes(line: 189 - 196)

""

..
        Type superClass = beanClass.getGenericSuperclass();
        while (superClass != Object.class)
        {
            decoratedTypes.remove(superClass);
            superClass = superClass.getClass().getGenericSuperclass();
        }
        decoratedTypes.remove(Object.class);
        decoratedTypes.remove(java.io.Serializable.class); /* 8.1 */
..

Is a decorator not supposed to inherit from another class ?