[OWB-575] ResourceProxyHandler.invoke should unwrap and throw the underlying cause of the InvocationTargetException

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0, 1.1.0
• Fix Version/s: 1.2.0
• Component/s: Java EE Integration, TCK
• Environment: any
• Assignee: Mark Struberg
• Reporter: Rohit Dilip Kelapure
• Created: 24/May/11 15:36
• Updated: 26/Jun/13 07:18
• Resolved: 10/Apr/13 20:55

Description

Right now the ResourceProxyHandler simply rethrows the exception resulting from an invoke.
There may be cases where the ResourceProxyHandler needs to throw the root cause of the exception upstream instead of the wrapped InvocationException.
ResourceProxyHandler.invoke needs to unwrap the root cause exception from the invoke and pass it up the chain since.
This change is conceptually similar to https://issues.apache.org/jira/browse/OWB-554

This defect is needed to resolve a org.jboss.jsr299.tck.tests.implementation.simple.resource.persistenceContext.PersistenceContextInjectionTest TCK failure since the TCK looks for the IllegalStateException as noted below.
try

{ entityManager.getTransaction(); // <-- entityManagerValid = false; }

catch (IllegalStateException e)

{ // an IllegalStateException is the expected result if this is a JTA entityManager }

An IllegalStateException is not caught though - because it looks like it is being wrapped by a java.lang.reflect.InvocationTargetException.

proposed Fix:
@Override
public Object invoke(Object self, Method actualMethod, Method proceed, Object[] args) throws Throwable
{
Object rc = null;
try

{ rc = actualMethod.invoke(this.actualResource, args); }

catch (InvocationTargetException ite)

{ throw ite.getCause(); }

catch (IllegalArgumentException e)

{ throw e.getCause(); } catch (IllegalAccessException e) { throw e.getCause(); }

return rc;
}