[ORCHESTRA-68] RequestParameterProviderManager.encodeAndAttachParameters might throw NullPointerException

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5
• Fix Version/s: 1.6
• Component/s: RequestParameterProvider
• Assignee: Leonardo Uribe
• Reporter: Leo Büttiker
• Created: 10/Aug/16 13:58
• Updated: 11/Aug/16 23:54
• Resolved: 11/Aug/16 23:54

Description

Under certain circumstances which I unfortunately can not reproduce all the time (during a heavy load selenium test with ajax) the method RequestParameterProviderManager.encodeAndAttachParameters throws an expection because a provider in the list providers is null.

The assumption is that due to multi-threading the array list might get corrupt under certain conditions. When I replace the list with a synchronized list the error does not occur. Fixing the bug can therefor achieved by replacing getProviders with:

    protected List getProviders() {
        if (providers == null) {
            providers = Collections.synchronizedList(new ArrayList());
        }

        return providers;
    }