[ORCHESTRA-58] ConversationManager should use equals to check for dummy id

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 1.4
• Fix Version/s: 1.5
• Component/s: Conversation
• Assignee: Jakob Korherr
• Reporter: Jakob Korherr
• Created: 14/Jul/11 16:12
• Updated: 14/Jul/11 16:34
• Resolved: 14/Jul/11 16:21

Description

(from Mathias Scharl)

The ConversationManager uses a DUMMY variable set to new Integer(-1). Later in the code this DUMMY is used to check for an invalid conversation id. Unfortunately this check is done via == instead of equals, which works most of the time, but after re-starting an application in tomcat (session is passivated), the DUMMY object is not the same anymore and the check does not work as expected. The solution is to use equals instead of ==.

Issue Links

• duplicates: ORCHESTRA-52 ConversationManager.getInstance throws ClassCastException comparing DUMMY object