[ORCHESTRA-17] RequestParameterFacesContextFactory only works with HttpServletResponse

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0, 1.1
• Fix Version/s: 1.4
• Component/s: RequestParameterProvider
• Environment: Liferay Portlet Container
• Assignee: Leonardo Uribe
• Reporter: Martin Marinschek
• Created: 11/Mar/08 14:23
• Updated: 15/Oct/09 17:13
• Resolved: 15/Oct/09 17:13

Description

The following snippet wrongly casts to HttpServletResponse, therefore portlet-environments will not work:

if (response instanceof HttpServletResponse)
{
HttpServletRequest httpServletRequest = (HttpServletRequest) request;

// Wrap this request only if something else (eg a RequestParameterServletFilter) has not already wrapped it.
if (!Boolean.TRUE.equals(httpServletRequest.getAttribute(RequestParameterServletFilter.REQUEST_PARAM_FILTER_CALLED)))
{

I will commit a solution very soon.

regards,

Martin

Issue Links

• is related to: ORCHESTRA-24 conversationContext param in url is missing; this breaks orchestra completely