Uploaded image for project: 'MyFaces Orchestra'
  1. MyFaces Orchestra
  2. ORCHESTRA-14

ConversationManagerSessionListener leak & IllegalStateException

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1
    • Fix Version/s: 1.1
    • Component/s: Conversation
    • Labels:
      None
    • Environment:
      tomcat 5

      Description

      ConversationManagerSessionListener has serveral issues:

      1) attributeReplaced sets the old instance of conversationManager in conversationWiperThread instead of the new one
      2) on session expire ConversationManagerSessionListener.attributeRemoved is getting called and session.getId() throws IllegalStateException
      3) ConversationManagerSessionListener.sessionDestroyed will throw a IllegalStateException as well -> method is useless

      Solution:
      1) use a unique id for conversationManager instead of session.getId() as a key in conversationWiperThread
      2) remove HttpSessionListener interface from ConversationManagerSessionListener

        Attachments

          Activity

            People

            • Assignee:
              tomsp Thomas Spiegl
              Reporter:
              tomsp Thomas Spiegl
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: