Uploaded image for project: 'ORC'
  1. ORC
  2. ORC-992

Reached max repeat length, we can directly decide to use DELTA encoding

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.8.0
    • 1.8.0
    • Java
    • None

    Description

      Reached max repeat length, we can directly decide to use DELTA encoding.
      RunLengthIntegerWriterV2.java 756-760

                // if fixed runs reached max repeat length then write values
                if (fixedRunLength == MAX_SCOPE) {
                  determineEncoding();
                  writeValues();
                }
      

      If fixed runs reached max repeat length. We have been able to determine the use of the DELTA code, fixedDelta is zero.

      The computeZigZagLiterals, zzBits100p, and determine isFixedDelta within the determineEncoding method are all redundant in the current case.

      Similar practices.
      RunLengthIntegerWriterV2.java 767-775

                if (fixedRunLength >= MIN_REPEAT) {
                  if (fixedRunLength <= MAX_SHORT_REPEAT_LENGTH) {
                    encoding = EncodingType.SHORT_REPEAT;
                  } else {
                    encoding = EncodingType.DELTA;
                    isFixedDelta = true;
                  }
                  writeValues();
                }
      

      Attachments

        Issue Links

          Activity

            People

              Guiyankuang Yiqun Zhang
              Guiyankuang Yiqun Zhang
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: