[ORC-873] Fix FindCyrusSASL to use the package name `CyrusSASL` instead of `CYRUS_SASL`

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.0, 1.6.9, 1.8.0
• Fix Version/s: 1.7.0, 1.8.0, 1.6.10
• Component/s: C++
• Assignee: Dongjoon Hyun
• Reporter: Dongjoon Hyun
• Created: 27/Jul/21 06:45
• Updated: 12/Aug/21 16:52
• Resolved: 27/Jul/21 17:28

Description

CMake Warning (dev) at /opt/homebrew/Cellar/cmake/3.21.0/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args` (CYRUS_SASL)
  does not match the name of the calling package (CyrusSASL).  This can lead
  to problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  cmake_modules/FindCyrusSASL.cmake:46 (find_package_handle_standard_args)
  cmake_modules/ThirdpartyToolchain.cmake:432 (find_package)
  CMakeLists.txt:130 (INCLUDE)
This warning is for project developers.  Use -Wno-dev to suppress it.

Issue Links

• links to: GitHub Pull Request #783