Uploaded image for project: 'ORC'
  1. ORC
  2. ORC-841

Remove Superfluous Array Fill in StringHashTableDictionary

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.8.0
    • 1.8.0
    • None
    • None

    Description

      StringHashTableDictionary.java
        private void doResize(int newCapacity, int oldCapacity) {
          // ...
          Arrays.fill(hashBuckets, null);
          hashBuckets = resizedHashBuckets;
        }
      

      No need to waste time to null-out of hashBuckets. hashBuckets is overwritten and the Java GC will clean it up, and by extension, all of its elements.

      Attachments

        Issue Links

          Activity

            People

              belugabehr David Mollitor
              belugabehr David Mollitor
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: