[ORC-840] Remove Superfluous Array Fill in RecordReaderImpl

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.8.0
• Fix Version/s: 1.8.0
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 09/Jul/21 16:29
• Updated: 03/Sep/22 22:43
• Resolved: 18/Jul/21 12:24

Description

public static int[] mapSargColumnsToOrcInternalColIdx(
                            List<PredicateLeaf> sargLeaves,
                            SchemaEvolution evolution) {
    int[] result = new int[sargLeaves.size()];
    Arrays.fill(result, -1);
    for(int i=0; i < result.length; ++i) {
      String colName = sargLeaves.get(i).getColumnName();
      result[i] = findColumns(evolution, colName);
    }
    return result;
  }

There is no reason here to pre-populate result with -1 values. They are promptly overwritten in the following loop.

Issue Links

• links to: GitHub Pull Request #744