[ORC-834] Do Not Convert to String in DecimalFromTimestampTreeReader

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.8.0
• Fix Version/s: 1.8.0
• Component/s: Java
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 07/Jul/21 16:48
• Updated: 03/Sep/22 22:43
• Resolved: 16/Aug/21 21:46

Description

Seen this elsewhere and it doesn't usually end well. Do not convert-to-string and then parse-from-string. Go directly to Decimal from the values provided.

https://github.com/apache/orc/blob/fb0ed31f15d9b77b76bc5dec8721f5d9ee129879/java/core/src/java/org/apache/orc/impl/ConvertTreeReaderFactory.java#L956-L962

Issue Links

• links to: GitHub Pull Request #743