[ORC-831] Do Not Copy String When Flushing Dictionary

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.8.0
• Fix Version/s: 1.8.0
• Component/s: Java
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 02/Jul/21 21:01
• Updated: 03/Sep/22 22:43
• Resolved: 13/Jul/21 06:28

Description

        if (useDictionaryEncoding) {
          rowOutput.write(dumpOrder[rows.get(i)]);
        } else {
          dictionary.getText(text, rows.get(i));
          directStreamOutput.write(text.getBytes(), 0, text.getLength());
          lengthOutput.write(text.getLength());
        }

The code to flush first loads (copies) the data into a Text object and then writes it to the direct stream. Instead, pass the directStream to the dictionary and have it write directly to the stream instead of an intermediate Text object.

Issue Links

• causes: ORC-954 Fix Javadoc generation failure
• links to: GitHub Pull Request #736