[ORC-830] Do Not Copy String When Adding to StringHashTableDictionary

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.8.0
• Component/s: Java
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 02/Jul/21 19:23
• Updated: 11/Aug/23 05:05
• Resolved: 11/Aug/23 05:05

Description

StringHashTableDictionary.java

    Text tmpText = new Text();
    for (int i = 0; i < candidateArray.size(); i++) {
      getText(tmpText, candidateArray.get(i));
      if (tmpText.equals(newKey)) {
        return candidateArray.get(i);
      }
    }

When there is a collision adding a value into a StringHashTableDictionary, a temp Text object is created and then each value in the byte array is copied into the temp Text until a match is found (or worst-case scenario, a match is not found and every value is loaded).

Instead of loading (copying) the values, just compare directly against the byte array without copying the data into a intermediate (temp) buffer.

Issue Links

• blocks: ORC-842 Remove newKey from StringHashTableDictionary
• links to: GitHub Pull Request #735