[ORC-492] ArrayIndexOutOfBoundsException in OrcFile

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.1, 1.6.12
• Fix Version/s: 1.7.2
• Assignee: Yiqun Zhang
• Reporter: Thippana Vamsi Kalyan
• Created: 18/Apr/19 06:43
• Updated: 02/Feb/22 23:55
• Resolved: 11/Nov/21 04:16

Description

https://github.com/apache/orc/blob/fd0b9f9f1a25d37614e2ad79c273b74e7ee02617/java/core/src/java/org/apache/orc/OrcFile.java#L238

Earlier code did not handle possible negative values for array index, and latest code handles the case.

Following is the check that handles negative index value. Based on code review, I see an issue with code when (versions.length == val).

if (val < 0 || versions.length < val) {
 return FUTURE;
}
WriterVersion result = versions[val];

In case versions.length == val, it should still throw ArrayIndexOutOfBoundsException

Issue Links

• links to: GitHub Pull Request #961