[ORC-442] [C++] Code improvements in Statistics and Writer

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Component/s: C++
• Assignee: Fang Zheng
• Reporter: Fang Zheng
• Created: 29/Nov/18 22:47
• Updated: 02/Dec/18 23:13
• Resolved: 02/Dec/18 23:13

Description

A few code changes in Statistics and Writer classes:

1. Change StatisticsImpl to use vector instead of list for storing ColumnStatistics. Because the required operations are push_back() in ctor, iteration in dtor, and random element access in getColumnStatistics(), and list does not support random access in constant time, vector would be more appropriate than list.

2. InternalBooleanStatistics is currently typedef-ed as InternalStatisticsImpl<uint64_t>. Since min/max/sum does not apply to BooleanColumnStatistics, we should define InternalBooleanStatistics to be InternalStatisticsImpl<char> to save 21 bytes per instance.

3. Misc. changes to ColumnWriter.hh, Writer.cc, Compression.hh, and Statistics.hh to fix typos in Doxygen and reduce object copies.

Please see PR for details.

Issue Links

• links to: GitHub Pull Request #343