[ORC-419] Ensure to call `close` at RecordReaderImpl constructor exception

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.5.0, 1.5.1, 1.5.2, 1.5.3
• Fix Version/s: 1.5.4, 1.6.0
• Component/s: Java
• Assignee: Dongjoon Hyun
• Reporter: Dongjoon Hyun
• Created: 11/Oct/18 05:54
• Updated: 02/Jan/19 19:12
• Resolved: 18/Oct/18 00:10

Description

Currently, there is no way to call `RecordReaderImpl.close` if `RecordReader.rows` fails at creating `RecordReaderImpl`. This issue aims to try to invoke `close` in the constructor in case of Exceptions.

  @Override
  public RecordReader rows(Options options) throws IOException {
    LOG.info("Reading ORC rows from " + path + " with " + options);
    return new RecordReaderImpl(this, options);
  }

Issue Links

• is related to: SPARK-23390 Flaky test: FileBasedDataSourceSuite
• relates to: SPARK-25688 Potential resource leak in ORC
• links to: GitHub Pull Request #322
• links to: GitHub Pull Request #323
• links to: GitHub Pull Request #324
• links to: GitHub Pull Request #325